jeremy/GITC-574/grants explorer routing change #9663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
jeremyschuurmans
force-pushed
the
jeremy/GITC-574/grants-explorer-routing-change
branch
from
8680145 to
e8eaf95
Compare
ksolo
reviewed
Nov 4, 2021
Comment on lines
+6
to
+12
| beforeEach(() => { | ||
| cy.impersonateUser(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| cy.logout(); | ||
| }); |
There was a problem hiding this comment.
are these needed for this test?
There was a problem hiding this comment.
I don't think the afterEach is necessary, but we definitely need the impersonateUser
There was a problem hiding this comment.
If you have to log in for this page, then you will need to make sure to log out after the test. If you need the impersonateUser then keep the logout. Cypress will keep that user in session and it could cause state issues for the next test. I expected the grants page to be public.
There was a problem hiding this comment.
Ah that makes sense. I'll put it back, but I just tested it on the production site, and the pages are public. The test breaks without impersonateUser() though.
ksolo
approved these changes
Nov 8, 2021
|
LGTM, thanks! |
thelostone-mc
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the link to the Grants Explorer on the Products dropdown to route to the explorer rather than the grants page.
Screen.Recording.2021-11-04.at.12.21.04.PM.mov
Refers/Fixes
Testing
This PR includes a Cypress test