Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant sidebar #9654

Merged
merged 7 commits into from
Nov 23, 2021
Merged

feat: grant sidebar #9654

merged 7 commits into from
Nov 23, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 2, 2021

Description

Revamps sidebar on grant details page

Order of events:

  • Message from admin
  • Inactive Grant
  • Verify Grant
  • Idle Grant
  • L2 contributions
  • Edit Grant Button
Refers/Fixes

closes #9650
closes #9651
closes #9652
closes #9653

Testing

Screenshot 2021-11-02 at 1 00 29 PM

Untitled

@thelostone-mc thelostone-mc force-pushed the detail branch 3 times, most recently from d375819 to f204f01 Compare November 9, 2021 04:37
@thelostone-mc thelostone-mc marked this pull request as ready for review November 15, 2021 10:54
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ksolo
Copy link
Contributor

ksolo commented Nov 18, 2021

@thelostone-mc can you add a test for the new grant method (is_idle)

Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 (Pending the test case @ksolo mentioned ^)

@thelostone-mc
Copy link
Member Author

@ksolo could you point me to an example I can use for adding tests for a property ?

@thelostone-mc thelostone-mc merged commit 0cd2af9 into gitcoinco:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants