GITC-505: Grants explorer search improvements #9627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
force-pushed
the
gitc-505/grants-explorer-search-improvements
branch
from
578f522 to
831cd4b
Compare
ksolo
requested review from
gdixon,
thelostone-mc,
chibie and
jeremyschuurmans
and removed request for
gdixon
ksolo
commented
Oct 25, 2021
app/grants/views.py
Outdated
| @@ -777,7 +777,7 @@ def get_grants_by_filters( | |||
|
|
|||
| def get_grant_type_cache(network): | |||
| try: | |||
| return JSONStore.objects.get(view=f'get_grant_types_{network}').data | |||
| return [JSONStore.objects.get(view=f'get_grant_types_{network}').data] | |||
There was a problem hiding this comment.
This looks like it was retrieving a dictionary and the front end is expecting an array. I wrapped it in a list to work with the front end. I'm happy to adjust how this is fixed.
There was a problem hiding this comment.
The stored value should be a list:
ksolo
commented
Oct 25, 2021
ksolo
commented
Oct 25, 2021
ksolo
force-pushed
the
gitc-505/grants-explorer-search-improvements
branch
from
b1629a4 to
0dc9856
Compare
gdixon
reviewed
Oct 28, 2021
added 9 commits
October 28, 2021 12:59
ksolo
force-pushed
the
gitc-505/grants-explorer-search-improvements
branch
from
43622d2 to
ce4fc61
Compare
gdixon
approved these changes
Nov 3, 2021
| # assert bounty.title_or_desc == "TitleTest" | ||
| # bounty.title = None | ||
| # assert bounty.title_or_desc == "HTTP API Documentation" | ||
|
|
There was a problem hiding this comment.
Was this failing? Why have we commented it out?
There was a problem hiding this comment.
He's removed out commented out code. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add enhancements to the search experience:
Refers/Fixes
GITC-505
Testing
Reviewed with Will locally