Integration: Checkout & collections integration #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide estimator if wallet not connected - hide modal prompt on deleting item from cart - show % in input field - fix spacing issue on clear cart - fix empty cart state - replace trash with times icon - add GrantsCart title - fix z-index issue on summary - custom boostrap split dropdown - change container col - change padding on tooltip - update color in donation suggestions
…-from-explorer' into checkout-collections-integration
gdixon
requested review from
chibie,
frankchen07,
PixelantDesign and
thelostone-mc
as code owners
ksolo
reviewed
Oct 22, 2021
| }, | ||
|
|
||
| totalString() { | ||
| const token = Object.keys(this['donationsTotal'])[0]; |
There was a problem hiding this comment.
This is relying on the order of the keys, is there a way to ensure the ordering or a way to find the appropriate key that is not dependent on order?
There was a problem hiding this comment.
So it wouldn't matter here cause all of them would use the same token! When you chekout -> you pick one token for all checkouts within a chain
Comment on lines
+106
to
+111
| collection_title: document.collection_title, | ||
| collection_description: document.collection_description, | ||
| collection_owner: document.collection_owner, | ||
| collection_owner_url: document.collection_owner_url, | ||
| collection_owner_avatar: document.collection_owner_avatar, | ||
| collection_grant_ids: document.collection_grant_ids, |
There was a problem hiding this comment.
with all the collection prefixing, we can wrap this in an object. (not a blocker at all)
| @@ -99,7 +99,8 @@ Vue.component('grants-ingest-contributions', { | |||
|
|
|||
| // Verify signature | |||
| if (!isValidSignature(signature)) { | |||
| throw new Error(`Invalid signature: ${signature}`); | |||
| console.error('Invalid signature', signature); | |||
There was a problem hiding this comment.
was this for debugging or is it intended to be available in prod?
chibie
approved these changes
Oct 25, 2021
thelostone-mc
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of the following:
GITC-407 - Grants ETH Checkout (#9572)
GITC-455 - View collection flow (#9580)
GITC-463 - Create collection flow (#9579)
GITC-454 - Collection explorer (#9584)
GITC-456 - Collection owner actions flow (#9585)
GITC-453 - Add grant to collection from explorer (#9591)
Testing
This branch is live on staging