add test for render_start_work_new_applicant method #9594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
ksolo
reviewed
Oct 15, 2021
|
|
||
| @pytest.mark.django_db | ||
| class InterestFactory(factory.django.DjangoModelFactory): | ||
| """Create mock Bounty for testing.""" |
There was a problem hiding this comment.
I am guessing this is copy/paste error? Should this be a mock Interest?
There was a problem hiding this comment.
These are also not mock objects. They are real instances of the Django classes. The Factory makes them easy to create for testing purposes.
thelostone-mc
approved these changes
Oct 18, 2021
jeremyschuurmans
force-pushed
the
jeremy/add-test-for-render-start-work-new-applicant
branch
from
c2f67cd to
643fe02
Compare
gdixon
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds unit testing to ensure that the
reject_worker_urlis present inrender_start_work_new_applicantThis is related to this issue on Jira: https://gitcoin.atlassian.net/jira/software/c/projects/GITC/boards/2?modal=detail&selectedIssue=GITC-379
The fix for that issue has been deployed
Refers/Fixes
Testing