Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed log out link #9555

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Changed log out link #9555

merged 1 commit into from
Oct 4, 2021

Conversation

julian-st
Copy link
Contributor

log out link was broken before

Description

The redirect link is now going to / instead of the current path

Refers/Fixes

#9493

Testing

Go to https://gitcoin.co/settings/account
Press the user drop-down. Then try to log out.

log out link was broken before
@thelostone-mc
Copy link
Member

Hmm i see what you're doing here! This makes sense for pages which don't need the user to be logged in.
Would it work for pages like gitcoin.co/grants/explore ?
where when i sign out -> it keeps me on gitcoin.co/grants/explore

@jeremyschuurmans jeremyschuurmans self-requested a review October 4, 2021 13:37
@chibie chibie merged commit 1009a17 into gitcoinco:master Oct 4, 2021
thelostone-mc added a commit that referenced this pull request Oct 4, 2021
thelostone-mc added a commit that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants