feat: show round / claim status on CLR page #9544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
zlsgh
as code owners
ksolo
suggested changes
Oct 1, 2021
There was a problem hiding this comment.
Can you update the model tests to reflect the new properties?
https://github.com/gitcoinco/web/blob/master/app/grants/tests/models/test_grant_clr.py
|
reviewed the video on #9549, left a couple of comments |
chibie
suggested changes
Oct 4, 2021
ksolo
approved these changes
Oct 4, 2021
chibie
approved these changes
Oct 4, 2021
jeremyschuurmans
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This does not make any changes to the landing page on explorer as discussed with @frankchen07 as having a generic claim with diff periods does not scale
Refers/Fixes
https://gitcoin.atlassian.net/browse/GITC-466
Testing
https://giphy.com/gifs/FnZ0sZM0h4K1vf2Jso/fullscreen