Add grants unit tests #9511
Merged
Add grants unit tests #9511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
force-pushed
the
add-grants-unit-tests
branch
from
9a4c987 to
69bb98a
Compare
added 2 commits
September 22, 2021 13:33
* create new directory for models, copy over Contribution model * extract grants models to individual files * rename relocated_models directory, remove original models directory, add imports, resolve circular dependencies * extract CLRMatch into separate file * extract Flag into separate file * extract MatchPledge to separate file * extract Donation and PhantomFunding * extract GrantStat into separate file * refactor * extract GrantBrandingRoutingPolicy to separate file * update migration * add missing import to MatchPledge, remove imports from __init__.py * add missing import * decouple GrantCLRCalculation and move to own file * extract GrantType to own file * extract GrantCLR to own file * add missing import * refactor, add missing imports * remove whitespace * resolve circular dependency * run 'make fix' * import changes from #9314 * add try/except to migration file instead of editing migration directly * refactor
jeremyschuurmans
force-pushed
the
add-grants-unit-tests
branch
from
69bb98a to
81f1318
Compare
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
zlsgh
approved these changes
Sep 27, 2021
ksolo
approved these changes
Sep 27, 2021
gdixon
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add-grants-unit-testsrebased ontomasterThis PR contains the prep work done for adding unit testing to the grants models. It doesn't contain any new tests.
The
extract-grants-models-into-individual-filesbranch was merged into this branch (extract-grants ...was already approved previously) and this branch was then rebased ontomaster, so this PR contains work already approved.I verified that each of the new model files were exactly like the models in the original
models.pyfile, including any recent changes that occurred after the original work on this was done.Some of the changes in this PR are irrelevant to the work I did and appear to be formatting adjustments that occurred when I ran
make fixFor easy reference, those files are:
Refers/Fixes
Testing
No tests yet, as this is prep work for adding more tests.