purge: ptokens #9485
Merged
purge: ptokens #9485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
force-pushed
the
purge
branch
3 times, most recently
from
f2514fc to
595ad60
Compare
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
zlsgh
as code owners
thelostone-mc
force-pushed
the
purge
branch
from
492831c to
a9f5993
Compare
gdixon
approved these changes
Sep 27, 2021
ksolo
reviewed
Sep 27, 2021
Comment on lines
+16
to
+25
| # migrations.AddField( | ||
| # model_name='activity', | ||
| # name='ptoken', | ||
| # field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='ptoken_activities', to='ptokens.PersonalToken'), | ||
| # ), | ||
| # migrations.AddField( | ||
| # model_name='activity', | ||
| # name='redemption', | ||
| # field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='ptokens.RedemptionToken'), | ||
| # ), |
There was a problem hiding this comment.
Is there a reason to keep this around? I'd prefer to delete unused code over commenting it out and leaving it in. We can always pull this back from git if it's needed.
There was a problem hiding this comment.
So this is only cause it's a migration which are auto generated !
Ideally we wouldn't want to change this but when we remove a django it causes travis to complain as it runs through the boot
thelostone-mc
force-pushed
the
purge
branch
from
7054ee1 to
cbe78d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes personal tokens
Refers/Fixes
GITC-409
Flows Tested