Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bulk add for collections #9463

Merged
merged 1 commit into from
Sep 27, 2021
Merged

add bulk add for collections #9463

merged 1 commit into from
Sep 27, 2021

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Sep 9, 2021 •
edited
Loading

Description
  • when using the search if "enter" is pressed execute the query.
  • If Im seeing a collection I can add all the collection to my cart with one click

image

Refers/Fixes

Based on discord users feedback
unblock #9460

https://gitcoin.atlassian.net/browse/GITC-402

Testing

@zlsgh
Copy link
Contributor

zlsgh commented Sep 10, 2021

Didn't we intentionally remove the bulk add collection to cart recently? @PixelantDesign @frankchen07

@chibie
Copy link
Contributor

chibie commented Sep 11, 2021

@octavioamu is there a limit to how many grants can be in a collection?

thelostone-mc
thelostone-mc approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise LGTM.
Still not sure on the bulk add as a feature but defer to product here

@octavioamu
Copy link
Contributor Author

@octavioamu is there a limit to how many grants can be in a collection?

I don't think so

gdixon
gdixon approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @octavioamu!! 🚀

@gdixon gdixon merged commit 91a8284 into stable Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdixon gdixon gdixon approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@chibie chibie Awaiting requested review from chibie

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

@zlsgh zlsgh Awaiting requested review from zlsgh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@octavioamu @zlsgh @chibie @thelostone-mc @gdixon