Cypress testing/add grant creation test #9461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
force-pushed
the
cypress-testing/add-grant-creation-test
branch
from
05e3085 to
cdf0ebb
Compare
ksolo
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
ksolo
force-pushed
the
cypress-testing/add-grant-creation-test
branch
from
3c90a68 to
3517ce1
Compare
ksolo
force-pushed
the
cypress-testing/add-grant-creation-test
branch
2 times, most recently
from
d3232e1 to
d6b4275
Compare
ksolo
force-pushed
the
cypress-testing/add-grant-creation-test
branch
3 times, most recently
from
c06ecd0 to
6d11d7a
Compare
thelostone-mc
approved these changes
Sep 20, 2021
* updating dependencies to use custom fork of cypress-metamask * add script and options for running cypress tests * add wait-on package for scripting cypress runs * travis docs indicate that bionic will start xvfb by adding it as a service * add migration step * another attempt at including cypress tests * redirect webserver logs to /dev/null * bad idea to move stdout to dev/null * add NETWORK_NAME to travis env file * update runserver command to go to background * updating existing cypress tests to run on ci * update docker-compose file: use default accounts for ganache * add set -x to get more visibility into cypress command args * update call to cypress run to see if travis will recognize flags * try running cypress directly from node_modules * remove set -x now that arguments are making their way to cypress
update ci to only run grant creation update migration this migration has already been executed on production and will be skipped when migrating deploys. updated to allow new uses and the ci environment to properly load the grant categories, which is required when creating a new grant. remove specifying which spec to run see if grant test can pass in isolation whoops - forgot to add the backslash grant passing in isolation, will all tests pass fix broken test with tag updates try running without touching metamask use npm ci on travis, update before/after hooks in cypress go back to npm install remove node_modules from cache use yarn to install dependencies remove debugger
ksolo
force-pushed
the
cypress-testing/add-grant-creation-test
branch
from
020be19 to
5466a90
Compare
ksolo
commented
Sep 20, 2021
zlsgh
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add end-to-end test for creating a new grant
Updates include:
Testing
These tests can run on CI