Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon copy updates #9445

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Polygon copy updates #9445

merged 1 commit into from
Sep 15, 2021

Conversation

zlsgh
Copy link
Contributor

@zlsgh zlsgh commented Sep 7, 2021

Description

Updating some of the Polygon copy to read better.

Testing

Tested locally, but needed to bump the ipdb version as in this PR to run Docker locally.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy changes LGTM
Left a comment on unrelated change

Let's also squash the commits! 5 commits for 4 lines of change isn't very clean

requirements/base.txt Outdated Show resolved Hide resolved
@zlsgh zlsgh force-pushed the polygon-copy-updates branch from 40ea1b3 to fb8a4f0 Compare September 13, 2021 13:04
@zlsgh
Copy link
Contributor Author

zlsgh commented Sep 13, 2021

@thelostone-mc Squashed and updated base branch. Ready to go.

@zlsgh zlsgh requested a review from thelostone-mc September 13, 2021 13:06
@thelostone-mc thelostone-mc merged commit ba529c5 into master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants