chore: clean up Critical and high code scanning alerts flagged in Github #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
zlsgh
as code owners
zlsgh
reviewed
Sep 9, 2021
| @@ -1006,7 +1006,7 @@ def grants_type_redirect(request, grant_type): | |||
| base_url = reverse('grants:grants_by_category', kwargs={"grant_type":grant_type}) | |||
| query_string = urlencode(request.GET) | |||
| url = '{}?{}'.format(base_url, query_string) | |||
| return redirect(url) | |||
| return redirect(url, code=302) | |||
There was a problem hiding this comment.
Github is flagging this as well. If this is a false positive, let's "Dismiss" and mark it as that.
zlsgh
approved these changes
Sep 9, 2021
chibie
approved these changes
Sep 14, 2021
octavioamu
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
GITC-307