bug: sentry fixes #9334
Merged
bug: sentry fixes #9334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
zlsgh
as code owners
chibie
approved these changes
Aug 10, 2021
zlsgh
reviewed
Aug 10, 2021
|
@zacheryschiller if you notice those aren't related to changes made on this PR ! We can open up a follow up PR to fix those up |
zlsgh
approved these changes
Aug 16, 2021
gdixon
reviewed
Aug 16, 2021
| @@ -2161,7 +2161,7 @@ def user_card(request, handle): | |||
| except (ProfileNotFoundException, ProfileHiddenException): | |||
| raise Http404 | |||
|
|
|||
| if request.user.is_authenticated: | |||
| if request.user.is_authenticated and request.user.profile: | |||
There was a problem hiding this comment.
Is this a symptom of a different problem? Why do we have authenticated users without Profiles?
There was a problem hiding this comment.
** As discussed we will get this in now and open a new ticket to investigate the cause
gdixon
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Testing
Tested locally