GITC-233: Cleans up static_url removal from bundled assets and ensures that ts checks are functional #9311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that ts checks are functional
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
thelostone-mc
approved these changes
Jul 22, 2021
chibie
approved these changes
Jul 22, 2021
zlsgh
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the block is being rendered as a template (by the bundle command) prior to being passed through the bundle templatetag, we must ensure that the
static_urland appended file hash is properly removed from the requested filenames.To be sure that we're removing the correct 12 chars (the file hash), this PR rewrites the regex to include the static_url in the match.
This PR also ensure that timestamps are being properly read from files loaded with a
base_dirattr to avoid unnecessarily regenerating unchanged assets.Refers/Fixes
Fixes: GITC-233
Testing
Tested locally under production like setting