Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITC-234 bug: user being able to fire multiple start work events #9310

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 21, 2021

Description

Report from Algorand:
Hi all, we found a potential bug of Gitcoin in one of our bounty: https://gitcoin.co/issue/algorandfoundation/grow-algorand/79/100026111
A user named “igarrestu” somehow managed to apply to this bounty multiple times and you can see the record in the bounty page.
Would you consider this is bug in Gitcoin’s anti-spam feature?

We already have backend checks for this.
The only time this issue occurs is when users fire click the interest button in quick sucessions -> leading the check to fail as
the first request is yet to have been saved.

This PR fixes ensure the frontend disables the button preventing the user from clicking it multiple times

Refers/Fixes

GITC-234

Testing

Tested locally.

@chibie chibie self-requested a review July 21, 2021 07:23
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

Copy link
Contributor

@zlsgh zlsgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thelostone-mc thelostone-mc changed the title bug: user being able to fire multiple start work events GITC-234 bug: user being able to fire multiple start work events Jul 22, 2021
@thelostone-mc thelostone-mc marked this pull request as ready for review July 22, 2021 01:45
@thelostone-mc thelostone-mc merged commit c9bd061 into gitcoinco:stable Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants