Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITC-102: Hackathons landing page (developers) refresh #9304

Merged
merged 8 commits into from
Jul 26, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Jul 19, 2021

Description

This PR implements the hackathons landing page refresh.

build design that includes:

  • hackathon landing page header & footer CTAs for exploring & becoming a sponsor
  • hackathons explorer preview (lead-in to CTA)
  • hackathon positive results from developers (testimonials)
  • hackathon landing page CTA to read instructions on how to get started (happyfox)
  • responsive views
Refers/Fixes

Fixes: GITC-102
Fixes: GITC-232

Testing

Tested locally

localhost_8000_hackathon-list

@gdixon gdixon force-pushed the GITC-102--hackathons-refresh branch from db951d0 to 11da59a Compare July 19, 2021 11:49
<div class="mt-3 font-smaller-2">
<div class="mb-1 text-grey-400">Sponsored by</div>
{% for sponsor in event.sponsor_profiles|slice:":6" %}
<a href="{{ sponsor.absolute_url }}" target="_blank"><img class="rounded-circle my-1 mr-1" style="width:36px;" src="{{ sponsor.avatar_url }}" /></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding noopener/noreferrer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do, but these are internal links - they're pointing to the sponsors profile (this code is unchanged from the original hackathon-list.html page)

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left one minor comments

Copy link
Contributor

@zlsgh zlsgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I pulled it and tested locally too. I think it's good to move forward. We need to make sure the content at the HappyFox link is updated before we deploy (https://support.gitcoin.co/kb/article/81-hackathons-how-it-works)

@owocki
Copy link
Contributor

owocki commented Jul 19, 2021

some feedback. some is about design, some about implmenetation

  • current hackathon landing page has a big giant 'contact sales' at top but this one doesnt. why is it so buried below the fold?
  • is the testimonials module meant to just have 1 sad lonely testimonial from cryptomental or is it meant to have many u can scroll thru? why doesnt cryptomental have a pic?
  • i get a 500 when i click to any hackathon https://stage.gitcoin.co/hackathon/sovrython/onboard

@gdixon
Copy link
Contributor Author

gdixon commented Jul 19, 2021

why doesnt cryptomental have a pic?

We're pulling that image from http://stage.gitcoin.co/dynamic/avatar/cryptomental - for some reason the dynamic end-point on staging is failing and I've not had chance to dig into why yet (its likely because we don't have s3 connected and all of this data was copied from production without any of the assets).

This works on both my local and on production (https://gitcoin.co/dynamic/avatar/cryptomental/) - I can have a look to get it going again tomorrow.

Ahhh, sorry about that, I hadn't ran the migrations - that should work now -- please note that I've placed the JSONstore manually to reflect the state of production, so some hackathons won't be present on staging.

Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

Header
I'm noticing extra space between
Hey Hackers, go build cool stuff and Build a bunch of cool stuff, learn new tech, support the open source ecosystem, and earn cash and prizes!. Consider removing extra space. See mission page header spacing.

Sponsor Hackathon
Want to become a sponsor or run an exclusive hackathon on Gitcoin?
This feels like a system alert (less of a promotion), as it follows our system alert design.

How to Get Started
Could we consider switching the How to get started section and the Get the latest on Gitcoin email newsletter section?

Email Newsletter
Email newsletter section, when I entered my email, I didn't receive a confirmation message (see mission page newsletter module).

cc @willsputra

@willsputra
Copy link
Contributor

willsputra commented Jul 20, 2021

current hackathon landing page has a big giant 'contact sales' at top but this one doesnt. why is it so buried below the fold?

Sponsor Hackathon
Want to become a sponsor or run an exclusive hackathon on Gitcoin?
This feels like a system alert (less of a promotion), as it follows our system alert design.

Since this page is more optimised for hackers, we want explore hackathons to be the primary CTA. We also wanted to provide a bit more context for funders that they can either be a sponsor or run exclusive hacks with us.

We can update the design to make it more obvious tho (and not clash with our system design) as below cc @PixelantDesign
@gdixon would it be difficult to change the sponsor section design to this?

Screenshot 2021-07-20 at 8 28 42 PM

I'm noticing extra space between
Hey Hackers, go build cool stuff and Build a bunch of cool stuff, learn new tech, support the open source ecosystem, and earn cash and prizes!. Consider removing extra space. See mission page header spacing.

Email Newsletter
Email newsletter section, when I entered my email, I didn't receive a confirmation message (see mission page newsletter module).

agree with these.

How to Get Started
Could we consider switching the How to get started section and the Get the latest on Gitcoin email newsletter section?

I'd still prefer putting the How to get started at the bottom so new users understand the what > why > how


A couple more questions:

  1. Are we building the new Prizes field? We talked about having a new field for prizes in USD that admins can enter manually.
    Screenshot 2021-07-20 at 8 36 43 PM

  2. For the floating bubbles, I understand we went with hackathon logos due to performance reasons. Would there be alternative ways to display org logos instead, say maybe pulling all org logos that are hackathon sponsors instead of pulling from leaderboard?
    Because the purpose of the bubbles is to inform "hey here's a lot of big-name projects you can work with" (for hackers) and "hey here are other big-name projects that have run hackathons with us, so don't miss out" (for sponsors), it'd be better to have recognisable org logos. But if the effort or performance hit is too big, this is fine for now 🙂

@gdixon
Copy link
Contributor Author

gdixon commented Jul 21, 2021

We can update the design to make it more obvious tho (and not clash with our system design)

This is resolved in b2e2acd

I'm noticing extra space between

Hey Hackers, go build cool stuff and Build a bunch of cool stuff, learn new tech, support the open source ecosystem, and earn cash and prizes!. Consider removing extra space. See mission page header spacing.

This is resolved in 3f09665

Email newsletter section, when I entered my email, I didn't receive a confirmation message (see mission page newsletter module).

Nice catch @PixelantDesign - thats now resolved in b2e2acd

A couple more questions:

  1. Are we building the new Prizes field? We talked about having a new field for prizes in USD that admins can enter manually.

Yes, that will be picked up when it is filled in the backend, the data on staging was a duplicate of whats on production, and the field won't be available until this PR is deployed.

  1. For the floating bubbles, I understand we went with hackathon logos due to performance reasons. Would there be alternative ways to display org logos instead, say maybe pulling all org logos that are hackathon sponsors instead of pulling from leaderboard?

Yes, let's split this out into a separate ticket, we will have to have a think about how we curate that list to ensure all sponsors are highlighted fairly.

Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gdixon gdixon force-pushed the GITC-102--hackathons-refresh branch from 2804b25 to 6435b9a Compare July 22, 2021 12:41
@gkimbwala
Copy link

This looks pretty good to me. There is a minor detail that catches my eye. I am not sure why the "join Now" buttons and "prizes" label on the current hackathons are two different colors. A little confused by that but other than that it looks good.
Screen Shot 2021-07-22 at 9 48 02 AM

@gdixon
Copy link
Contributor Author

gdixon commented Jul 22, 2021

This looks pretty good to me. There is a minor detail that catches my eye. I am not sure why the "join Now" buttons and "prizes" label on the current hackathons are two different colors. A little confused by that but other than that it looks good.

This state shows when the hackathon event has reached an end but before the page cache has been regenerated (which would move the event in to the completed tab).

In the old design those buttons were removed, but because that would leave a lot of empty space, I opted to disable them instead. If someone from the team was to go in to the _admin panel, they would be able to trigger the cache to be regenerated manually (or we can wait for the cron to trigger the refresh (it runs once every 3 hours)).

So this state is rare, but it does handle an edge-case (you cannot join a hackathon after it has ended).

@gkimbwala
Copy link

This looks pretty good to me. There is a minor detail that catches my eye. I am not sure why the "join Now" buttons and "prizes" label on the current hackathons are two different colors. A little confused by that but other than that it looks good.

This state shows when the hackathon event has reached an end but before the page cache has been regenerated (which would move the event in to the completed tab).

In the old design those buttons were removed, but because that would leave a lot of empty space, I opted to disable them instead. If someone from the team was to go in to the _admin panel, they would be able to trigger the cache to be regenerated manually (or we can wait for the cron to trigger the refresh (it runs once every 3 hours)).

So this state is rare, but it does handle an edge-case (you cannot join a hackathon after it has ended).

Got it! Then it looks good to me.

<script src="https://cdn.jsdelivr.net/npm/[email protected]/index.min.js"></script>
<script src="{% static "v2/js/lib/svgator_player.js" %}"></script>
<script src="{% static "v2/js/bubbles.js" %}"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goood one

tabs = [
('current', 'happening now', num_current),
('upcoming', 'upcoming', num_upcoming),
('finished', 'completed', num_finished),
]

# shuffle the sponsors
random.shuffle(sponsors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@gdixon gdixon merged commit 4776e34 into master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants