Fix AnonymousUser post on status #9261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
chibie
suggested changes
Jul 6, 2021
| response['status'] = 401 | ||
| response['message'] = 'Not logged in!' | ||
| print('here', response) | ||
| return JsonResponse(status=response['status'], data={'status': 401,'message':response['message']}) |
There was a problem hiding this comment.
can we just do return JsonResponse(response, status=401) ?
There was a problem hiding this comment.
how it works is status 401 http status and data.status json pattern, not sure I get your feedback, could be like:
return JsonResponse(status=401, data={'status': 401,'message':response['message']})
zlsgh
suggested changes
Jul 14, 2021
chibie
approved these changes
Jul 19, 2021
gdixon
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
fix https://gitcoin.atlassian.net/browse/GITC-166
Testing