Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straw man fix for gitcoin.co/townsquare?dressing=1 being hella flow #9250

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 2, 2021

Description

Looking at the datadog trace its clear to me that the lookup for activity counts (to show on the badges) is the slow part in a production like env

this pr removes those, under the judgement call that the badges arent worth a 30s load time (and the subsequent load on the db that comes from that).

in the future, refactoring on the activity table (maybe just a db index, but it probably is getting big enough it doesnt belong in postgres too) may be necessary if we want to query this table deeply in the future

Refers/Fixes

https://gitcoincore.slack.com/archives/CAXQ7PT60/p1625158054329700
https://app.datadoghq.com/apm/traces?query=env%3Aprod%20service%3Adjango%20resource_name%3A%2Atownsquare%2A%20%40duration%3A%3E%3D12.5s&index=apm-search&spanID=1926285002054291218&streamTraces=true&traceID=15069572059855755779&start=1625234553487&end=1625235453487&paused=false

Testing

Tested Locally

@thelostone-mc thelostone-mc merged commit ac3e744 into master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants