Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make improvs to missing contiribution ingestions #9242

Merged
merged 1 commit into from
Jul 1, 2021
Merged

chore: make improvs to missing contiribution ingestions #9242

merged 1 commit into from
Jul 1, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 1, 2021 •
edited
Loading

Description

Based on discussion here
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1625073981307100

This PR

  • Adds better validation to ensure admin don't post random data
  • Tweaks admin view to handle contributions with missing profilr (due to invalid data entry)
  • Improves error messaging on the contribution ingestion page
Refers/Fixes

GITC-125

Testing

uninstall_wv

@thelostone-mc thelostone-mc merged commit 64d136d into gitcoinco:stable Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibie chibie Awaiting requested review from chibie

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@gdixon gdixon Awaiting requested review from gdixon

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

@zlsgh zlsgh Awaiting requested review from zlsgh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thelostone-mc