hotfix - twilio ddos fix #9237
Merged
hotfix - twilio ddos fix #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
|
note engineering team: - i did not get a chance to test as im on a laptoip without docker privisioned and in between calls. can you quickly test before shipping? |
gdixon
approved these changes
Jun 30, 2021
|
a graceful failure eg "Youre ratelimited -Please try again in 1 minute" would prob be nice |
zlsgh
approved these changes
Jun 30, 2021
…eText for sms-verification
|
It looks like the reason we were getting so many requests to the whitepaper was because it was set as the response to ratelimited requests - I've changed that and added the error response to the front-end for sms-verification 👍
|
octavioamu
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some butthead is going in and ddosing our twilio account with twilio verify requests, which cost like 1c each... and in aggregate costing us hundreds of $$$$ per round.
this PR adds a rate limit to the twilio endpoint call so that it cant be done anymore.
ideally we'd extend this even further and block ppl who abuse the system as such.. but i dont have cycles to code that today
Refers/Fixes
https://app.datadoghq.com/logs?query=request_user_sms&index=
https://www.twilio.com/console/verify/services
Testing
did not test, but its a simple addition of a rate limit so hope its ok