chore: fix earning tables #9236
Conversation
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
zlsgh
as code owners
|
code seems sane to me i havent tested, but id love to see where it hiccups on a prod-db-backup before running on prod |
|
also you should run this report before/after and see if anything goes wonky eg if anyone has a 100000000000000 GMV in USD after you know something went wrong |
|
Yup i'll have it run on staging and see how that plays out @gitcoinco/engineers could you guys check it out ? once we agree it looks sane -> I'll run it on staging |
| tokens = Token.objects.filter(approved=True) | ||
|
|
||
| for bounty_fulfillment in bounty_fulfillments: | ||
| token_name = bounty_fulfillment.token_name |
There was a problem hiding this comment.
we're using filter, here so it should be fine
|
|
||
|
|
||
| # filter earning which have txid | ||
| earnings_with_txid = earnings_mainnet.filter(txid__isnull=False).exclude(txid__exact='') |
There was a problem hiding this comment.
It would be worth excluding 0x0 here too (theres 2538 of them on prod) - and it might be a good idea to clear their usdt values?
There was a problem hiding this comment.
would be worth excluding 0x0 here too
makes sense
and it might be a good idea to clear their usdt values?
I'm not sure if this is something we should do right now. might need a lil bit more analysis for this
cause these seem to come from std bounties which may not have been wired in right
|
|
||
|
|
||
| # filter earning which have txid | ||
| earnings_with_txid = earnings_mainnet.filter(txid__isnull=False).exclude(txid__exact='') |
| """Fix earnings.""" | ||
|
|
||
| print("Pulling in every Earning") | ||
| # e = Earning.objects.all() |
There was a problem hiding this comment.
Did you mean to leave this commented code in?
There was a problem hiding this comment.
Ah that is dead code! not needed
|
|
||
|
|
||
| # ============================= STEP 4 ======================= | ||
| # fetch only bounty fulfillments and fixes decimal issue |
There was a problem hiding this comment.
Should say only tips instead of only bounty fulfillments
There was a problem hiding this comment.
Will purge this a day after we release. So izz okay
This was simply to get the team to 👀 on what I was trying to do here
Description
This PR ends up
- A) updating the value in Earnings Table with the right amount for
- B) setting Earning to false if the contributions was false
- C) updated BountyFulfillments payout_amount when if it's not represented in it's normalized value
- D) fixed code where BountyFulfillments payout_amount is not stored as normalized value
- E) increase the token_value to 18 decimals in Earnings Model
Refers/Fixes
https://metabase.gitcoin.co/question/1054
Testing
Has been tested locally with snapshot of live data