GITC-108: Fixes 500 errors when bounty.name contains unicode chars #9226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
thelostone-mc
approved these changes
Jun 30, 2021
zlsgh
reviewed
Jun 30, 2021
zlsgh
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the project_page by ensuring any
project.namecontaining unicode is decoded prior to slugifying (this same fix is applied to every use of slugify across the codebase), also DRYs up the process by declaring URLs in the model avoiding the need to recreate them on the frontend and corrects some minor styling issues.unidecodeas a dependencyRefers/Fixes
Fixes: GITC-108
Testing
Tested locally