GITC-80: remove unused templates #9207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibie
requested review from
frankchen07,
gdixon,
octavioamu,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
chibie
force-pushed
the
GITC-80--remove-unused-templates
branch
from
182dd02 to
dda94fe
Compare
|
Looks good cleaning up all this! I didn't see anything under "Testing" above. Did you test all the products locally to make sure we aren't accidentally removing something we need? |
thelostone-mc
approved these changes
Jul 6, 2021
@zacheryschiller I don't think you'd actually be able to test this. Doing a manual check while reviewing is probably the safest way to review this PT |
thelostone-mc
added a commit
that referenced
this pull request
Jul 9, 2021
This reverts commit e8767ab.
thelostone-mc
added a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused templates based on output from https://github.com/AMeng/django-unused-templates/blob/master/django_unused_templates.py
some extra care taken
return TemplateResponse(request, f'quadraticlands/mission/{mission_name}/question_{question_num}.html', context)Refers/Fixes
Testing