ReadY for Review - Quadraticlands diplomacy (a medley of Aditya/Richard/Owocki Code) #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in progress
- added a view in claim.html that tell users they have 0 tokens + give them the option to complete the mission by forward to outro. - added a hidden div that forward claimable token amount via data-atribute to js world - added a check in claim.js for token amount = 0 to update the claim view on load
- index / room template - artworks - embed in /missions
- room list ( index page ) v1 done - room detail - todo
owocki
commented
Jun 11, 2021
owocki
commented
Jun 11, 2021
owocki
commented
Jun 30, 2021
owocki
changed the title
owocki
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
zlsgh
as code owners
owocki
commented
Jul 2, 2021
owocki
commented
Jul 2, 2021
owocki
changed the title
thelostone-mc
approved these changes
Jul 9, 2021
gdixon
approved these changes
Jul 9, 2021
| @@ -122,6 +122,7 @@ async function fetchAccountData(provider) { | |||
| // MetaMask does not give you all accounts, only the selected account | |||
| console.log('Got accounts', accounts); | |||
| selectedAccount = accounts[0] || provider.account; | |||
| // selectedAccount = '0x1402e01ba957e030200ec21e1417dc32c11e486b'; | |||
There was a problem hiding this comment.
Should this be removed before we push it out?
There was a problem hiding this comment.
i kept just for the sake of testing ! will remove it out once we test it out in live as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quadratic Diplomacy, a tool where useres can stake their GTC on each other and improve each others trust bonus by doing so.
v1 features:
for next version (hopefully by GR11):
Refers/Fixes
#anti-sybil-staking in
Testing
tested locally and it works well!
PLEASE TEST ON A FRESH QUAD LANDS DB, THERE ARE SOME CHANGES WHERE IF U PREVIOUSLY PULLED + TRY TO TEST THOSE ROOMS IT WONT WORK