Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Implements the "Me Menu" #8985

Merged
merged 4 commits into from
Jun 7, 2021
Merged

feature: Implements the "Me Menu" #8985

merged 4 commits into from
Jun 7, 2021

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Jun 3, 2021 •
edited
Loading

Description

This PR implements the "Me Menu":

  • adds many additional links to the menu (could reviewers please check that these all lead to the most appropriate places)
  • adds the option for ltr and rtl submenus (with hysteresis checks in both directions)
  • exposes the submenus content on mobile
Refers/Fixes

Closes: #8923

Testing

Tested locally

Screenshot 2021-06-03 at 23 19 16

Screenshot 2021-06-03 at 06 39 06

@gdixon gdixon merged commit dc40144 into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlsgh zlsgh zlsgh approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@octavioamu octavioamu octavioamu approved these changes

@chibie chibie Awaiting requested review from chibie

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
grants_round_10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitcoin "Me" Menu / Nav 2.0
4 participants
@gdixon @octavioamu @thelostone-mc @zlsgh