Fix/double requests #8959
Merged
Fix/double requests #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
gdixon
approved these changes
May 28, 2021
app/dashboard/tasks.py
Outdated
| @@ -294,6 +294,7 @@ def increment_view_count(self, pks, content_type, user_id, view_type, retry: boo | |||
| :param view_type: | |||
| :return: | |||
| """ | |||
| print(pks, content_type, user_id, view_type) | |||
There was a problem hiding this comment.
Consider: dropping this print
app/grants/views.py
Outdated
| @@ -595,6 +595,11 @@ def get_grants(request): | |||
| del grant_json['weighted_risk_score'] | |||
| grants_array.append(grant_json) | |||
|
|
|||
| pks = list([grant.pk for grant in grants]) | |||
| if len(pks): | |||
| print(request.user) | |||
app/grants/views.py
Outdated
| @@ -867,6 +872,7 @@ def grants_landing(request): | |||
|
|
|||
| def grants_by_grant_type(request, grant_type): | |||
| """Handle grants explorer.""" | |||
| print(request) | |||
|
Could we remove the print and move this to master as opposed to stable ? |
|
Allll done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove query on view load of grant explorer, instead just use the js request for the api.
Refers/Fixes
Fixes: #8846
Testing