Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deb image to Stretch #888

Merged
merged 3 commits into from
Apr 27, 2018
Merged

Upgrade deb image to Stretch #888

merged 3 commits into from
Apr 27, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Apr 14, 2018

Description

The goal of this PR is to upgrade our web image to extend from the stretch python image tag versus jessie. Additionally, this PR upgrades some of our pinned python packages.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

Built image and tested general functionality locally.

@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #888 into master will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   32.81%   33.65%   +0.84%     
==========================================
  Files         100       99       -1     
  Lines        6613     6034     -579     
  Branches      809      721      -88     
==========================================
- Hits         2170     2031     -139     
+ Misses       4336     3912     -424     
+ Partials      107       91      -16
Impacted Files Coverage Δ
app/app/utils.py 19.58% <0%> (-3.35%) ⬇️
app/dashboard/admin.py 68.62% <0%> (-3.31%) ⬇️
app/dashboard/notifications.py 14.45% <0%> (-2.01%) ⬇️
app/app/settings.py 81.37% <0%> (-1.29%) ⬇️
...eting/management/commands/assemble_leaderboards.py 52.45% <0%> (-0.82%) ⬇️
app/gitcoinbot/actions.py 64.23% <0%> (-0.43%) ⬇️
...eting/management/commands/expiration_start_work.py 79.62% <0%> (-0.38%) ⬇️
app/marketing/views.py 11.65% <0%> (-0.08%) ⬇️
app/tdi/views.py 19.07% <0%> (-0.03%) ⬇️
app/dashboard/embed.py 6.77% <0%> (-0.03%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b457e44...e160c0f. Read the comment docs.

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you feel like it's well tested

django==2.0.4
django-bootstrap3==8.2.3
django-bootstrap3==9.1.0
Copy link
Member

@thelostone-mc thelostone-mc Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbeacom Thoughts on shifting to django-bootstrap4 ?

It's mentioned in bootstrap3 change log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to... but I didn't want to make any major changes to the python packages in this PR. The main thing here is the upgrade from jessie to stretch for LTS and upgraded system packages like OpenSSL jumping to 1.1

We can definitely raise a PR following this to upgrade to django-bootstrap4 - Thanks for looking out @thelostone-mc 😛 - If no one has objections, we could try it in this PR. Looking to merge this following #668

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot post #668 merge :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just rip out django-bootstrap3 since it's unused throughout the codebase.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@mbeacom mbeacom merged commit c3e0441 into master Apr 27, 2018
@mbeacom mbeacom deleted the mark-upgrade-docker-base branch April 27, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants