-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade deb image to Stretch #888
Conversation
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 32.81% 33.65% +0.84%
==========================================
Files 100 99 -1
Lines 6613 6034 -579
Branches 809 721 -88
==========================================
- Hits 2170 2031 -139
+ Misses 4336 3912 -424
+ Partials 107 91 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you feel like it's well tested
requirements/base.txt
Outdated
django==2.0.4 | ||
django-bootstrap3==8.2.3 | ||
django-bootstrap3==9.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbeacom Thoughts on shifting to django-bootstrap4 ?
It's mentioned in bootstrap3 change log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to... but I didn't want to make any major changes to the python packages in this PR. The main thing here is the upgrade from jessie
to stretch
for LTS and upgraded system packages like OpenSSL
jumping to 1.1
We can definitely raise a PR following this to upgrade to django-bootstrap4
- Thanks for looking out @thelostone-mc 😛 - If no one has objections, we could try it in this PR. Looking to merge this following #668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a shot post #668 merge :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably just rip out django-bootstrap3
since it's unused throughout the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
Description
The goal of this PR is to upgrade our
web
image to extend from thestretch
python image tag versusjessie
. Additionally, this PR upgrades some of our pinned python packages.Checklist
Testing
Built image and tested general functionality locally.