add client side validation #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu and
PixelantDesign
as code owners
chibie
suggested changes
Mar 29, 2021
| case 'qr': | ||
|
|
||
| if (token_name == 'BTC') { | ||
| if (address.toLowerCase().startsWith('0x')) { |
There was a problem hiding this comment.
This is displaying the error when a BTC address starts with 0x 👍
gdixon
reviewed
Mar 30, 2021
There was a problem hiding this comment.
Would it be worth moving this error state reporting to the method we use in the style guide?
http://localhost:8000/styleguide/components
It will mean we need to write up data-patterns for each of the chains so that we can properly toggle the ::invalid state, but it would add consistency. Bounty creation currently follows this pattern if you want to have a look at how its working atm.
|
@gdixon done
|
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
* add client side validation * address feedback * address feedback * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes