Improve performance on cart load #8702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
PixelantDesign
approved these changes
Mar 26, 2021
mds1
reviewed
Mar 26, 2021
Comment on lines
+1423
to
+1426
| // Make sure none have empty currencies, and if they do default to 0.001 ETH. This is done | ||
| // to prevent the cart from getting stuck loading if a currency is empty | ||
| updatedGrant[grantIndex]['grant_donation_currency'] = grant.grant_donation_currency ? grant.grant_donation_currency : 'ETH'; | ||
| updatedGrant[grantIndex]['grant_donation_amount'] = grant.grant_donation_amount ? grant.grant_donation_amount : '0.001'; |
There was a problem hiding this comment.
PR looks great! Just one small comment here: This should probably vary by tenant, right? It seems right now we set the default value to 0.001 ETH regardless of the grant's tenant
There was a problem hiding this comment.
only if not defined but I fixed the others areas to always be defined already, so probably this part will be deleted on some point is just a double check for security for now
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Testing
A lot of testing with diff chains and fixing consoles errors.
Improve the load performance
VID_20210325_181551.mp4