Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove override and allow close button clickable by admin #8697

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 25, 2021

Description

From connor

Problem: “Override status” button no longer works for admins after moving from standard bounties, admins have to “view in admin” and then type in “done” in override status field to close
Request: Fix “Override status” button on bounty frontend

The fix instead :

  • to expose close bounty button to admin
  • remove override status (this is done cause we don't want bounty jumping the states)
Testing

Screenshot 2021-03-25 at 4 20 34 PM

@connoroday
Copy link
Contributor

Looks great! This will definitely help. A further improvement (which may be another open issue) would be prompting the funder to close the bounty every time they pay out for a cooperative or contest bounty:

A modal pops up saying:
"Thanks for paying out! Would you like to close the bounty, or are you paying more users?"
With two buttons:
"Close bounty" or "I'm paying more prizes"

^This makes an admin having to close issues on behalf of funders much more rare

@frankchen07
Copy link
Contributor

I would say exposing the close bounty button for the funder is a great start to solving this problem. With contest or cooperative, let's see how they use the exposed closed button first before we go and add menu options for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants