fix buggy number on participants #8683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu and
PixelantDesign
as code owners
chibie
approved these changes
Mar 24, 2021
octavioamu
reviewed
Mar 24, 2021
Comment on lines
+4254
to
+4256
| all_participants = BountyEvent.objects.filter(bounty__event_id=hackathon_event.id, bounty__in=query_prizes) | ||
| num_participants = all_participants.count() | ||
| num_submissions = all_participants.filter(event_type='submit_work').count() |
octavioamu
approved these changes
Mar 24, 2021
| @@ -20,7 +20,7 @@ | |||
| from django.urls import path, re_path | |||
|
|
|||
| from grants.views import ( | |||
| add_grant_from_collection, bulk_fund, bulk_grants_for_cart, cancel_grant_v1, cart_thumbnail, clr_grants, | |||
| add_grant_from_collection, bulk_fund, bulk_grants_for_cart, cancel_grant_v1, cart_thumbnail, clr_grants, collage, | |||
There was a problem hiding this comment.
what is collage? I don't see it here
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Issue:
Problem: Sponsor dashboard still says 0 participants, should say the registrants #
Request: Sponsor dashboard should say number of participants, bugged right now
^ reported by @connoroday