Adds xDai to POAP verification #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Apr 5, 2021
iRhonin
pushed a commit
to iRhonin/web
that referenced
this pull request
Apr 23, 2021
* Updates POAPs abi, from_blocks and adds xDai verification * Tidies up logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Refers/Fixes
Refers: to a conversion with @Kweiss last week
Fixes: #8676
Testing
Tested locally -- as mentioned here #8640 (review), filtering the Transfer events seems to fail intermittently - as I don't have any POAP tokens on mainnet, I'm not sure if this is an issue only on xDai or with event filtering in general. It would be great if we could migrate to a service like Opensea's api - but I am yet to find one which deals with tokens held on xDai - does anyone have any ideas?