allow admin to opt out of CLR #8607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
chibie,
frankchen07,
gdixon,
octavioamu and
PixelantDesign
as code owners
chibie
approved these changes
Mar 16, 2021
gdixon
reviewed
Mar 16, 2021
gdixon
suggested changes
Mar 16, 2021
gdixon
reviewed
Mar 16, 2021
app/grants/views.py
Outdated
| @@ -1593,6 +1593,9 @@ def grant_edit(request, grant_id): | |||
| if not description_rich: | |||
| description_rich = description | |||
|
|
|||
| is_clr_eligible = json.loads(request.POST.get('is_clr_eligible', 'true')) | |||
| grant.is_clr_eligible = is_clr_eligible | |||
There was a problem hiding this comment.
Can we wrap this with if grant.active:?
There was a problem hiding this comment.
hmm well if a grant is not active -> this endpoint shouldn't be accessible via UI.
So ideally they would not be able to edit their grants right ?
There was a problem hiding this comment.
changed it anyways to be safer
thelostone-mc
force-pushed
the
is_clr_eligible
branch
from
c7e27ef to
62425ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is duplicate of https://github.com/gitcoinco/web/pulls and uses
is_clr_elgibleinstead of adding a new field cause we had a few support requests asking us to remove their grant from CLR