Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update can_submit_after_expiration_date #856

Merged
merged 2 commits into from
Apr 11, 2018
Merged

update can_submit_after_expiration_date #856

merged 2 commits into from
Apr 11, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Apr 10, 2018

Fixes: #855

@owocki
Copy link
Contributor Author

owocki commented Apr 10, 2018

can be tested with

from dashboard.models import Bounty
for bounty in Bounty.objects.filter(current_bounty=True).order_by('created_on'):
    print(bounty.github_url, bounty.is_legacy, bounty.web3_created.strftime("%Y-%m-%d"), bounty.can_submit_after_expiration_date)

but does not seem to be working rn

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #856 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage    33.9%   33.86%   -0.05%     
==========================================
  Files         101      101              
  Lines        5790     5797       +7     
  Branches      677      679       +2     
==========================================
  Hits         1963     1963              
- Misses       3747     3754       +7     
  Partials       80       80
Impacted Files Coverage Δ
app/dashboard/models.py 68.43% <0%> (-0.82%) ⬇️
app/dashboard/utils.py 23.21% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29e40a...4dbd451. Read the comment docs.

@owocki owocki changed the title WIP - update can_submit_after_expiration_date update can_submit_after_expiration_date Apr 10, 2018
@cryptomental
Copy link
Contributor

cryptomental commented Apr 10, 2018

@owocki @mbeacom I wrote test for this already, they will pass once the pr is merged + 90b4d93 is applied. Currently on master test case test_can_submit_standard_bounty_after_expiration_date_if_deadline_extended fails.

After I cherry-picked the commit from this branch I get.

app/dashboard/tests/test_dashboard_models.py::DashboardModelsTest::test_can_submit_legacy_bounty_after_expiration_date PASSED
app/dashboard/tests/test_dashboard_models.py::DashboardModelsTest::test_can_submit_standard_bounty_after_expiration_date_if_deadline_extended PASSED
app/dashboard/tests/test_dashboard_models.py::DashboardModelsTest::test_cannot_submit_standard_bounty_after_expiration_date PASSED

It is almost midnight here, so I will likely continue on tests tomorrow, just wanted to give a heads up that those codecov values will improve.

@owocki
Copy link
Contributor Author

owocki commented Apr 10, 2018

thanks @cryptomental !

@mbeacom let me know if looks okay to you

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@owocki owocki merged commit 4dc9461 into master Apr 11, 2018
@mbeacom mbeacom deleted the kevin/expiry_date branch April 11, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants