-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update can_submit_after_expiration_date #856
Conversation
can be tested with
but does not seem to be working rn |
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 33.9% 33.86% -0.05%
==========================================
Files 101 101
Lines 5790 5797 +7
Branches 677 679 +2
==========================================
Hits 1963 1963
- Misses 3747 3754 +7
Partials 80 80
Continue to review full report at Codecov.
|
@owocki @mbeacom I wrote test for this already, they will pass once the pr is merged + 90b4d93 is applied. Currently on master test case test_can_submit_standard_bounty_after_expiration_date_if_deadline_extended fails. After I cherry-picked the commit from this branch I get.
It is almost midnight here, so I will likely continue on tests tomorrow, just wanted to give a heads up that those codecov values will improve. |
thanks @cryptomental ! @mbeacom let me know if looks okay to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes: #855