Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nervos crosschain | bounties/hackathons #8550

Merged
merged 26 commits into from
Jun 7, 2021
Merged

feat: nervos crosschain | bounties/hackathons #8550

merged 26 commits into from
Jun 7, 2021

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Mar 11, 2021 •
edited
Loading

Description

Description

Bounties Integration

Frontend

  • Add chain to bounty creation + hack form form (staff flag)
  • Funder should be able to create bounty with nervos
  • User should be able to start / stop / submit work with nervos
  • Funder should be able to payout using web3

Backend

  • Add in chain sync logic
  • Fix fulfil flow for bounty
  • Change web3 type to nervos_ext
  • Fix Amount bug
  • testing
Refers/Fixes

#8438

Testing

create bounty + submit work -> https://www.loom.com/share/933c147955854db98e54a6e3a958e69c
bounty payout -> https://www.loom.com/share/2303204b24bb4f9988485ea20a97e0c9

@chibie chibie marked this pull request as ready for review April 14, 2021 18:48
@chibie chibie removed the blocked label May 10, 2021
@chibie chibie removed the dont merge label May 12, 2021
@chibie chibie requested a review from thelostone-mc May 14, 2021 01:52
@chibie chibie requested a review from zlsgh as a code owner June 1, 2021 12:19
gdixon
gdixon approved these changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me @chibie! Good job! 🚀

@thelostone-mc thelostone-mc merged commit fd4e792 into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlsgh zlsgh zlsgh approved these changes

@gdixon gdixon gdixon approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chibie @thelostone-mc @gdixon @zlsgh