Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Alters grants details page to match the new design #8490

Closed
wants to merge 1 commit into from

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Mar 5, 2021

Description

This PR implements the Grants Details page redesign, it is not yet complete - but all of the design is implemented and functional. I do however need some guidance on the following:

  • Where does the "Latest Contributions > View all" link take us? Is that a new page which needs to be produced?
  • Is the CLR graph an image or should it be a chart? If it is a chart, how can I calculate the trend?

@PixelantDesign / @willsputra

Refers/Fixes

Refers: #8449

Testing
  • Grant which has 0 Contributions & 0 Related Grants

localhost_8000_grants_4_test

  • Grant which has both Contributions & Related Grants - signed in as the Owner

localhost_8000_grants_3_my-test-grant-x3

  • Mobile view of the same Grant

localhost_8000_grants_3_my-test-grant-x3(iPhone 6_7_8 Plus)

@gdixon gdixon marked this pull request as draft March 5, 2021 09:52
@willsputra
Copy link
Contributor

willsputra commented Mar 5, 2021

@gdixon

Where does the "Latest Contributions > View all" link take us? Is that a new page which needs to be produced?

Yes a new page that shows all contributions. But if it's a high lift, a "Load More" button at the bottom that loads more contributions work too!

Is the CLR graph an image or should it be a chart? If it is a chart, how can I calculate the trend?

The chart shape will be the same for every grant, but the numbers will be our existing "$1 contribution -> $X match" and "$100 contribution -> $Y match"

@thelostone-mc
Copy link
Member

@gdixon Yo just listing out scenarios

  • grant is not part of an CLR // this means the grant_clrs fks is empty
  • grant is not eligible for CLR // toggled via admin
  • grant is not active // aka it cannot accept contributions. toggled via admin
  • ETH grants show eth address with logo, CELO grants show celo address with logo // cross chain functionality
  • grant is active CLR

@thelostone-mc
Copy link
Member

Closing this out cause we have wrapped this up 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants