record proper usd value of a bounty fulfillment

[owocki]

Description

https://gitcoin.co/nance2uiuc

that user paid out a $60k bounty, to 20 diff users. and instead of giving credit to the user for one $60k bounty the system did it 20 times.

this PR fixes that by taking the bounty fulfillment amount + creating the earning from that.

but this PR is blocked from being truly useful by the fact that bountyfulfillment.payout_amount is null for most objects in production ( #8486 )

Refers/Fixes

see above

Testing

tested locally

[thelostone-mc]

but this PR is blocked from being truly useful by the fact that bountyfulfillment.payout_amount is null for most objects in production ( #8486 )

When a bounty fulfillment is created AKA user submits work to a bounty -> the payout_amount is null
When the funder pays out -> only then is the payout_amount is set (as this may differ from bounty amount)

[thelostone-mc]

code wise LGTM. we can figure out the DRY code later

[owocki]

got it; then we will need to make the usd value on the earning update when the BF object is updating

…

On Thu, Mar 4, 2021 at 9:20 PM Aditya Anand M C ***@***.***> wrote: ***@***.**** approved this pull request. code wise LGTM. we can figure out the DRY code later — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8488 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCP6Q7MZETFXHWF3WETTCBL2TANCNFSM4YUC6OCA> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $11.1mm for Open Source Software - see our results <https://gitcoin.co/results>

[thelostone-mc]

got it; then we will need to make the usd value on the earning update when

the "value_usd":instance.value_in_usdt_then, change would take care of this right ?

[owocki]

i think so. based on how the defaults dict in Earning.objects.update_or_create performs, it looks like yes ( https://docs.djangoproject.com/en/3.1/ref/models/querysets/#update-or-create )

[thelostone-mc]

@gdixon so wrapping thus in a try-catch and returning None in the catch might help