Updates sentry-sdk (0.7.7->0.19.5) and introduces traces_sample_rate #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(provisionally set to 0.35) (gitcoinco#8309)
gdixon
requested review from
amustapha,
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
yo @octavioamu mind dropping the reasons why we set value as 0.35 -> just so folks can refer this PR later if needed |
thelostone-mc
approved these changes
Feb 3, 2021
@thelostone-mc - theres ~700 reqs/min and the example given in the docs (https://docs.sentry.io/product/performance/distributed-tracing/) is aiming for around ~250/min, (700 * 0.35 will give us ~245). If this looks like too few or too many samples in practice we can ratchet up or down once we see the data coming into sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the sentry-sdk version and introduces traces_sample_rate (set to sample 35% of requests).
Refers/Fixes
Refers: #8309
Testing
@octavioamu provided figures on reqs/min to get us to the 0.35 figure. If the load changes, we might need to readdress how much sampling we do.