Allow bounty onwer to stop worker. #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amustapha
requested review from
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
screenshot / recording ? |
|
Just added the video @thelostone-mc |
thelostone-mc
approved these changes
Feb 1, 2021
|
When would this fixed be deployed on production? This fix is not yet working for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the bounty owner tries to stop a worker who has been approved to work on a bounty, it doesn't happen and he simply gets an error. This happens because the endpoint for removing an interest from a bounty (stop worker) only does a worker check and not bounty owner check. This PR allows a worker to remove himself from a bounty and a bounty owner to stop a worker as well. It doesn't introduce a new functionality, only fixes a functionality that is broken.
Refers/Fixes
closes #8331
Testing
https://www.loom.com/share/8f269920f1f94ad09c980da5f6f05fed