Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle email subscription duplicate entry #8330

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Jan 29, 2021

Description

user has been unable to payout bounty https://gitcoin.co/issue/status-im/status-react/11488/100024619

this PR prevents the update of email subscription email if user profile email already has an entry.

Refers/Fixes

#8328

Additional Context

refer to ticket

Copy link
Member

@Kweiss Kweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines +30 to +32
grants_stats_view, ingest_contributions, ingest_contributions_view, invoice, leaderboard, manage_ethereum_cart_data,
new_matching_partner, profile, quickstart, remove_grant_from_collection, save_collection, subscription_cancel,
toggle_grant_favorite, verify_grant,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these imports used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's auto linting by pre-commit hook on grants/urls.py. they're used there.

not related to this PR

@thelostone-mc thelostone-mc merged commit e587938 into master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants