Drops a Grants Twitter verification if the user modifies the twitter_handle_1 field #8305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
amustapha,
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
gdixon
force-pushed
the
bugfix/edit-grant-twitter-verification
branch
from
1ca1aca to
3d33f33
Compare
|
@gdixon -> could you test it out and throw in a video? |
|
@thelostone-mc - I've set my local instance up with some Twitter keys and everything seems to be running smoothly (with some minor alterations to the front-end)... |
thelostone-mc
approved these changes
Jan 26, 2021
|
⚡️ A tip worth 0.08000 ETH (114.83 USD @ $1435.38/ETH) has been granted to @gdixon for this issue from @owocki. ⚡️ Nice work @gdixon! Your tip has automatically been deposited in the ETH address we have on file.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://gitcoin.co/grants/1924/gitcoin-grants-round-9-dev-fund
https://gitcoin.co/grants/1927/gitcoin-grants-official-matching-pool-fund-round-
Users are able to modify a Grants twitter handle after the verification process.
Replicated here: https://gitcoin.co/grants/1930/test-2
This pull will clear the verification if the twitter_handle_1 field is modified.
Refers/Fixes
clsoes #8303
Testing
Untested - I don't have my local instance set-up with a twitter_access_token yet, I can't see anything going wrong, but let me know if you want me to test it 👍