adds an is_pro flag to the profile, so that we can easily toggle users back and forth into pro features #8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
amustapha,
chibie,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Jan 26, 2021
app/dashboard/models.py
Outdated
| @@ -397,6 +397,7 @@ class Bounty(SuperModel): | |||
| default=False, help_text=_('This bounty will be part of the hypercharged bounties') | |||
| ) | |||
| hyper_next_publication = models.DateTimeField(null=True, blank=True) | |||
| is_pro = models.BooleanField(help_text=_('Is this use upgraded to pro?')) | |||
There was a problem hiding this comment.
I think this need to be on profile not on the bounty model as context is looking for profile.is_pro Unless Im missing something.
There was a problem hiding this comment.
coding is hard, thats why im a powerpoint guy these days.
fixed at ba14183
octavioamu
suggested changes
Jan 27, 2021
app/dashboard/models.py
Outdated
| @@ -397,6 +397,7 @@ class Bounty(SuperModel): | |||
| default=False, help_text=_('This bounty will be part of the hypercharged bounties') | |||
| ) | |||
| hyper_next_publication = models.DateTimeField(null=True, blank=True) | |||
| is_pro = models.BooleanField(help_text=_('Is this use upgraded to pro?')) | |||
There was a problem hiding this comment.
I think this need to be on profile not on the bounty model as context is looking for profile.is_pro Unless Im missing something.
|
@thelostone-mc @octavioamu fixed! ba14183 |
amustapha
approved these changes
Jan 31, 2021
chibie
approved these changes
Feb 1, 2021
|
conflicts + missing default value + migration out of date! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds an is_pro flag to the profile, so that we can easily toggle users back and forth into pro features
Refers/Fixes
https://gitcoincore.slack.com/archives/CCL5Q0G5S/p1611589993005000
Testing
tested locally