fix(landing): caps + btn alignment #8298
Conversation
chibie
requested review from
amustapha,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
Please add screenshot |
|
Also, based on the codes and the description, I can't see the bit that does "btn alignment". Did you miss some commits? |
|
@aamustapha i've added the missing commit 👀 |
|
Is there a specific reason you're adding container? Also, can you add a fullscreen screenshot so that we see as it aligns with the rest of the content. |
|
were numbers 3 & 4 also addressed on the ticket? #8277 |
|
@aamustapha here's a full screenshot
1,2,3 are done. can you provide more explanation for 4? should the buttons go above the paragraphs? |
|
Is this ggod to review ? |
|
@thelostone-mc yes it is |
|
@chibie number 4 I was thinking something like this. we bring the buttons up so they don't have to scroll to get to the buttons
this is taking in some of Joe's comments about having our CTAs being above the fold. cc @PixelantDesign, as design czar, what do you think? |
|
oh this makes sense now @frankchen07 |
|
adding one more thing @chibie, apologies for the scope changes.
This is based off of feedback from existing gitcoin users that they don't have a reliable way to login when they reach gitcoin.co. It eventually takes them to townsquare which isn't the optimal experience but it's a compromise between the landing page CTAs and existing users who just want to login, know the platform, and navigate to where they needed to go. |
| <a class="btn fe-pulse" href="/hackathon-list"><span>Join a Hackathon</span></a> | ||
| <a class="btn fe-pulse" href="/explorer"><span>Work on a Bounty</span></a> | ||
| <a class="btn fe-pulse" href="/grants"><span>Get Grant Funding</span></a> | ||
| </div> |
There was a problem hiding this comment.
@frankchen07 is this intended ? we show the same actions for
Here to earn and Here to support ?
|
@chibie looks like we're missing "the Ethereum [ecosystem] forward." under "Here to Support" can you add a video too? |
|
@frankchen07 i just added a screen recording to description |
|
hey @chibie thanks for this - just one small thing - is it possible to do the login just like the Grants page, with the same hover over effect for consistency? like this: https://www.loom.com/share/753abb5b8e9946b188ab47133610d80f Once they're logged in, gitcoin.co should reflect https://gitcoin.co/townsquare
after this, it will be LGTM. We'd like to get this deployed early next week. |
|
login hover effect ✅
|
Description
landing page fixes
Refers/Fixes
#8277
Testing
https://www.loom.com/share/c3462421f6c547ebb5e61908272466ee