Fixes: https://github.com/gitcoinco/web/issues/792 #827
Conversation
|
@willsputra Conflicts :P Oh could you throw in a screenshot, so that's it easier for folks to review ^_^ |
There was a problem hiding this comment.
@willsputra Could we
- re-indent the css files to 2 spaces as against 4
- run
npm run stylelint:fixand fix thecsserrors
And throw in a screenshot so that we make @PixelantDesign 's life easier for reviewing and get this merged :)
There was a problem hiding this comment.
You'll need to run make fix, make fix-stylelint, or npm run stylelint:fix to resolve the Travis failures. Can you also include the requested screenshots or a gif of the proposed changes per @thelostone-mc ?
|
@mbeacom you just copied what I said :P |
|
@thelostone-mc 🤷♂️ Just going down the list! 😅 |
|
oops thanks @mbeacom @thelostone-mc lemme try it out in a bit! |
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 33.97% 33.97%
=======================================
Files 101 101
Lines 5774 5774
Branches 672 672
=======================================
Hits 1962 1962
Misses 3733 3733
Partials 79 79Continue to review full report at Codecov.
|
|
@willsputra squash + screenshot !! |
|
screenshot here:
|
|
@willsputra looking good! I haven't looked at the latest changes so you may have already done this but make sure to do |
|
@mkosowsk Per the contributor guidelines, you should install |
|
@PixelantDesign This looks alright ? ^_^ |
|
apologies for the hiccup guys 🙏 |
|
@willsputra All good! Thank you for your contribution! |
|
@willsputra no worries and congrats on the contribution! I was just trying to be a smartass and give @mbeacom a hard time for repeating what @thelostone-mc said 😂 but then he went and provided some good insight 🤔 |
Description
Separated profile and username to 2 lines.
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes
Fixes: #792