Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grants: add harmony support #8220

Merged
merged 17 commits into from
Jan 19, 2021
Merged

grants: add harmony support #8220

merged 17 commits into from
Jan 19, 2021

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 8, 2021

Description
  • Grant Creation
  • Grant Detail Page (View + Update)
  • Add to Cart
  • Contribute Flow
    • when one wallet extension is not installed
    • when not enough balance
    • when wallet is locked
    • when sign is rejected
    • when signature is approved
  • Chain validation + sending email on successful validation

https://share.vidyard.com/watch/E47CWxua89CM8xM5PtcCLA?

@thelostone-mc thelostone-mc marked this pull request as ready for review January 13, 2021 05:44
app/assets/v2/js/cart.js Outdated Show resolved Hide resolved
app/grants/views.py Show resolved Hide resolved
@thelostone-mc thelostone-mc requested a review from chibie January 15, 2021 14:43
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good the only thing I noticed is the harmony tab is trying to connect with web3modal

@thelostone-mc
Copy link
Member Author

looking good the only thing I noticed is the harmony tab is trying to connect with web3modal

Yup this is something we'll have to fix for all non web3 related flows

@thelostone-mc thelostone-mc merged commit 0e3d0cf into master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants