todos should be falsy

[owocki]

@mbeacom i noticed this when dockerizing my setup: i think that the TODOs in the settings file shoudl be falsy, so that settings.GITHUB_CLIENT_ID (and others) are falsy... and we don't try to send out a bunch of github/twitter/slack notifications because of lines of code like this everywhere.

[codecov]

Codecov Report

Merging #821 into master will increase coverage by 1.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   34.34%   35.46%   +1.12%     
==========================================
  Files          99      102       +3     
  Lines        5768     6524     +756     
  Branches      674      878     +204     
==========================================
+ Hits         1981     2314     +333     
- Misses       3702     4111     +409     
- Partials       85       99      +14

Impacted Files	Coverage Δ
app/app/settings.py	79.8% <100%> (-1.7%)	⬇️
app/faucet/views.py	22.34% <0%> (-3.31%)	⬇️
app/app/urls.py	91.66% <0%> (-1.89%)	⬇️
app/external_bounties/views.py	17.24% <0%> (-0.86%)	⬇️
app/app/context.py	0% <0%> (ø)	⬆️
app/github/urls.py	100% <0%> (ø)
app/github/views.py	24.61% <0%> (ø)
app/github/middleware.py	0% <0%> (ø)
app/app/utils.py	20.37% <0%> (+0.21%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3639a...ae65f3c. Read the comment docs.

[mbeacom]

I'm good with this! One thing, though... couldn't we use '' for string types and it still return false without the possibility of passing NoneType where str is expected (if we're not checking if object is ? The main reason I used TODO for the default values was to maintain parity from the original local_settings.py/settings.py defaults.

[owocki]

@mbeacom good call.. just made that change.

[mbeacom]

lgtm