-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to the Landing page #8176
Conversation
* remove "Developers" & "Network" * add 2 new descriptions with buttons to "What is Gitcoin" sec. * move newsletter section to 3rd screen
Codecov Report
@@ Coverage Diff @@
## master #8176 +/- ##
==========================================
- Coverage 25.35% 20.99% -4.37%
==========================================
Files 329 316 -13
Lines 33401 33314 -87
Branches 4997 4991 -6
==========================================
- Hits 8470 6993 -1477
- Misses 24641 26273 +1632
+ Partials 290 48 -242
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments!
Could you also add a screenshot and ensure it also works for mobile display
@nglglhtr could you post a video? |
adding the copy to be added here: https://docs.google.com/document/d/1cDmUr80AbL1HfYLLou8lvIehVjGt-hw9ddXK9uueAkU/edit# |
here's the link to a desktop scroll video: https://www.icloud.com/iclouddrive/04Y5aseNyERZFCk0yJ7XuY1IQ#Screen_Recording_2021-01-08_at_6.59.52_PM |
Minor changes: "Get grant funding" -> can we keep the capitalization consistent? -> "Get Grant Funding" Does "Enter Gitcoin" just put them back on Townsquare? I would recommend removing the ability to just "enter" and end up on Townsquare because we've received plenty of feedback on how folks are confused when they get there. The onboarding idea for the landing page was to direct them down one specific path to reduce the problem of confusion. Is there any way to help this text stand out, or feel more like "points" rather than just text thrown on there? It's a bit hard to read:
I think it's supposed to be one word "upskill".
Should be a period. "...the ecosystem. Get involved..." The rest looks pretty good. Just from watching the video though, I still feel like the zoom is pretty strong. I would want to see more with less scrolling, but pp to design though cc @PixelantDesign |
can we merge this? |
I had a comment with a bunch of changes @nglglhtr, did they make it in? |
@frankchen07, Yes it does - can remove the button altogether for now
How does this look? The buildings in the background animation still get in the way though, if that still makes it harder to read, I'll get in touch with Richard to fix their height or opacity |
Fixed the heights of the buildings in the background to create more space for the text, here's an 8x video of the cover: landing-page.mp4& the entire landing: landing-page-full.mp4 |
* a slightly bigger font for inline use
@nglglhtr, the all caps for the actions look a little funny to me, and I feel like it crowds the space a little bit. Can we just simplify and remove all of the sub-text (START an open source project. LEARN ...etc.), and leave the larger title text there? So just keep: Everything else looks good to go! Thanks for helping out with these changes! :) |
@PixelantDesign + @frankchen07 do hit approve once the PR Is good from your side and I can get it in after that |
Yes, for sure, not a problem; I do not really have a strong opinion for or against a design change - my UI skillz are pretty much nonexistent lol; relying on yours & @PixelantDesign's judgement here :) |
I read the copy a few times to make sure that even though we remove the sub-text we're still conveying 90+% using the title, larger text. No worries, text is easy to change if we decide to do so with any new rebranding copy work. Thank you for the edits! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Refers/Fixes
#8171
Testing
Tested locally
Screenshots
Desktop
Mobile
Video
https://www.icloud.com/iclouddrive/04Y5aseNyERZFCk0yJ7XuY1IQ#Screen_Recording_2021-01-08_at_6.59.52_PM