Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the Landing page #8176

Merged
merged 14 commits into from
Jan 15, 2021
Merged

Changes to the Landing page #8176

merged 14 commits into from
Jan 15, 2021

Conversation

probablyangg
Copy link
Contributor

@probablyangg probablyangg commented Dec 23, 2020

Description
  • remove "Developers" & "Network"
  • add 2 new descriptions with buttons to "What is Gitcoin" sec.
  • move newsletter section to 3rd screen
Refers/Fixes

#8171

Testing

Tested locally

Screenshots

Desktop

image

image

image

Mobile

Screenshot 2021-01-08 at 6 51 01 PM

Screenshot 2021-01-08 at 6 51 14 PM

Screenshot 2021-01-08 at 6 51 20 PM

Screenshot 2021-01-08 at 6 51 26 PM

Video

https://www.icloud.com/iclouddrive/04Y5aseNyERZFCk0yJ7XuY1IQ#Screen_Recording_2021-01-08_at_6.59.52_PM

  * remove "Developers" &  "Network"
  * add 2 new descriptions with buttons to "What is Gitcoin" sec.
  * move newsletter section to 3rd screen
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #8176 (bcee454) into master (5265bdb) will decrease coverage by 4.36%.
The diff coverage is 18.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8176      +/-   ##
==========================================
- Coverage   25.35%   20.99%   -4.37%     
==========================================
  Files         329      316      -13     
  Lines       33401    33314      -87     
  Branches     4997     4991       -6     
==========================================
- Hits         8470     6993    -1477     
- Misses      24641    26273    +1632     
+ Partials      290       48     -242     
Impacted Files Coverage Δ
app/app/urls.py 86.20% <ø> (ø)
app/dashboard/admin.py 60.51% <0.00%> (-1.16%) ⬇️
app/dashboard/tip_views.py 14.85% <0.00%> (-0.06%) ⬇️
app/kudos/views.py 14.08% <0.00%> (-0.04%) ⬇️
app/quests/management/commands/re_rank_quests.py 0.00% <0.00%> (ø)
app/quests/helpers.py 19.56% <7.14%> (-0.44%) ⬇️
app/dashboard/models.py 37.80% <16.66%> (-12.02%) ⬇️
app/dashboard/utils.py 17.01% <16.66%> (-21.84%) ⬇️
app/kudos/models.py 48.55% <50.00%> (+<0.01%) ⬆️
app/quests/quest_types/quiz_style.py 28.00% <50.00%> (+0.97%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a53a5b...44e1ebd. Read the comment docs.

Copy link
Contributor

@amustapha amustapha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@Kweiss Kweiss linked an issue Dec 30, 2020 that may be closed by this pull request
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments!
Could you also add a screenshot and ensure it also works for mobile display

app/assets/landingpage/app.css Show resolved Hide resolved
app/retail/templates/home/index2020.html Show resolved Hide resolved
app/retail/templates/home/index2020.html Outdated Show resolved Hide resolved
@PixelantDesign
Copy link
Contributor

@nglglhtr could you post a video?

@probablyangg
Copy link
Contributor Author

@probablyangg
Copy link
Contributor Author

@nglglhtr could you post a video?

here's the link to a desktop scroll video: https://www.icloud.com/iclouddrive/04Y5aseNyERZFCk0yJ7XuY1IQ#Screen_Recording_2021-01-08_at_6.59.52_PM

@frankchen07
Copy link
Contributor

Minor changes:

"Get grant funding" -> can we keep the capitalization consistent? -> "Get Grant Funding"

Does "Enter Gitcoin" just put them back on Townsquare? I would recommend removing the ability to just "enter" and end up on Townsquare because we've received plenty of feedback on how folks are confused when they get there. The onboarding idea for the landing page was to direct them down one specific path to reduce the problem of confusion.

Screen Shot 2021-01-08 at 13 39 05

Is there any way to help this text stand out, or feel more like "points" rather than just text thrown on there? It's a bit hard to read:

Screen Shot 2021-01-08 at 13 38 22

up skill

I think it's supposed to be one word "upskill".

...the ecosystem, Get involved...

Should be a period. "...the ecosystem. Get involved..."

The rest looks pretty good. Just from watching the video though, I still feel like the zoom is pretty strong. I would want to see more with less scrolling, but pp to design though cc @PixelantDesign

@probablyangg
Copy link
Contributor Author

can we merge this?

@frankchen07
Copy link
Contributor

I had a comment with a bunch of changes @nglglhtr, did they make it in?

@probablyangg
Copy link
Contributor Author

probablyangg commented Jan 13, 2021

Does "Enter Gitcoin" just put them back on Townsquare? I would recommend removing the ability to just "enter" and end up on Townsquare because we've received plenty of feedback on how folks are confused when they get there. The onboarding idea for the landing page was to direct them down one specific path to reduce the problem of confusion.

@frankchen07, Yes it does - can remove the button altogether for now

Is there any way to help this text stand out, or feel more like "points" rather than just text thrown on there? It's a bit hard to read:

How does this look? The buildings in the background animation still get in the way though, if that still makes it harder to read, I'll get in touch with Richard to fix their height or opacity

image

@probablyangg
Copy link
Contributor Author

probablyangg commented Jan 13, 2021

Fixed the heights of the buildings in the background to create more space for the text, here's an 8x video of the cover:

landing-page.mp4

& the entire landing:

landing-page-full.mp4

  * a slightly bigger font for inline use
@frankchen07
Copy link
Contributor

@nglglhtr, the all caps for the actions look a little funny to me, and I feel like it crowds the space a little bit.

Can we just simplify and remove all of the sub-text (START an open source project. LEARN ...etc.), and leave the larger title text there?

So just keep:

Screen Shot 2021-01-13 at 13 26 38

Everything else looks good to go! Thanks for helping out with these changes! :)

@thelostone-mc
Copy link
Member

thelostone-mc commented Jan 14, 2021

@PixelantDesign + @frankchen07 do hit approve once the PR Is good from your side and I can get it in after that

@probablyangg
Copy link
Contributor Author

@nglglhtr, the all caps for the actions look a little funny to me, and I feel like it crowds the space a little bit.

Can we just simplify and remove all of the sub-text (START an open source project. LEARN ...etc.), and leave the larger title text there?

Yes, for sure, not a problem; I do not really have a strong opinion for or against a design change - my UI skillz are pretty much nonexistent lol; relying on yours & @PixelantDesign's judgement here :)

@probablyangg
Copy link
Contributor Author

probablyangg commented Jan 14, 2021

Updated screenshot:

image

@frankchen07
Copy link
Contributor

frankchen07 commented Jan 14, 2021

I read the copy a few times to make sure that even though we remove the sub-text we're still conveying 90+% using the title, larger text. No worries, text is easy to change if we decide to do so with any new rebranding copy work.

Thank you for the edits!

Copy link
Contributor

@frankchen07 frankchen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thelostone-mc thelostone-mc merged commit d731996 into master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new landing
6 participants