Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subcategories count #8166

Merged

Conversation

amustapha
Copy link
Contributor

@amustapha amustapha commented Dec 21, 2020

Description

When you toggle the dropdown for ZCash grants (or any grant category), the counts on the subcategories are showing total count for that subcategory not just the count of Zcash grant in that subcategory, The solution was to fix the query that inerts the count to Redis and JSONStore.

Refers/Fixes

closes #7795

Testing

@thelostone-mc
Copy link
Member

tested locally and it works :D neat job

@thelostone-mc thelostone-mc merged commit 3a240b6 into gitcoinco:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZCash grants subcategories on grants index page show count of ZCash + ETH grants combined
2 participants