Convert to Grant #8154
Merged
Convert to Grant #8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amustapha
requested review from
chibie,
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
thelostone-mc
approved these changes
Dec 21, 2020
|
@aamustapha what do you think about hiding the convert to grant button once the project has been made into a grant ! It doesn't make sense to have that button there once it's bren converted right ? ( Noticed this on the video )! |
|
Yes, I have done that in the updates |
amustapha
commented
Dec 22, 2020
Comment on lines
+53
to
+55
| {% if not project_obj.grant_url %} | ||
| <a :href="`/grants/new?title=${project.name}&description_rich=${project.summary}&reference_url=${project.work_url}&github_project_url=${project.work_url}&related_hackathon_project_id=${project.id}`" target="_blank" class="project__action--admin btn button-white btn-block font-subheader btn-lg m-2"><i class="fa fa-plus mr-2"></i>CONVERT TO GRANT</a> | ||
| {% endif %} |
There was a problem hiding this comment.
Here @thelostone-mc.
|
tested to make sure grant creation works! works chill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow Hackathon team members to spin off a grant from an existing hackathon.
Refers/Fixes
#7098
#7359
Testing
https://www.loom.com/share/a833c6e9bae54c70a5a6617ef7d72799